compiler: Enhance IR to support more advanced parlang (CUDA/HIP/SYCL) features#2748
compiler: Enhance IR to support more advanced parlang (CUDA/HIP/SYCL) features#2748FabioLuporini wants to merge 18 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
==========================================
- Coverage 83.05% 82.55% -0.51%
==========================================
Files 248 248
Lines 50294 50379 +85
Branches 4426 4431 +5
==========================================
- Hits 41773 41589 -184
- Misses 7763 8019 +256
- Partials 758 771 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| initvalue = tuple(i.subs(subs_user) for i in k) | ||
| w = weights[k] = w0._rebuild(name=name, dtype=dtype, initvalue=initvalue) | ||
|
|
||
| rebuilt = expr._subs(w0.indexed, w.indexed) |
There was a problem hiding this comment.
why not just expr._rebuild(weights=w)?
| def __hash__(self): | ||
| return hash((super().__hash__(), self.sub_iterators, | ||
| self.directions)) | ||
| return hash((super().__hash__(), self.sub_iterators, self.directions)) |
There was a problem hiding this comment.
Would having a hashable items attribute like we use in some other classes clean this up a little?
|
|
||
| """ | ||
| Abstract base class for all terminal objects, that is, those objects | ||
| collected by `retrieve_terminals` in addition to all other SymPy atoms |
There was a problem hiding this comment.
This is a somewhat tautologous definition. What conceptually is a "terminal" here?
|
closing as superseded by #2822 2822 |
3 participants
Supersedes #2717